feat: support for relative (percent) metrics in data contract checks.#1248
Open
HenrikSpiegel wants to merge 10 commits into
Open
feat: support for relative (percent) metrics in data contract checks.#1248HenrikSpiegel wants to merge 10 commits into
HenrikSpiegel wants to merge 10 commits into
Conversation
HenrikSpiegel
commented
May 20, 2026
jschoedl
requested changes
May 28, 2026
Collaborator
jschoedl
left a comment
jschoedl
left a comment
There was a problem hiding this comment.
Thank you for the PR! A few notes, and please add test cases for this in the tests directory - e.g.:
- test that
percentreally appends% - test that no
%exists for the default case orrows - test that e.g.
check_property_null_valueswith percent produces the correct sodacl check - test that a percent sign in
check_row_countbehaves correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv run pytest)uv run ruff check --fix && uv run ruff format)#1228